Skip to content

Conversation

@Florin-Popescu
Copy link

Hello!

I've found these really small changes required to be able to run this script under python3. Seeing as how python2 has been deprecated for 3 years now, I believe this could be updated in this repo too.

Hope this one makes sense.

@maxgerhardt
Copy link
Collaborator

Thanks for the contribution! Was this PR only to supposed to update scripts/io_gen.py? Content from other PRs seem to have slipped in here too.

@Florin-Popescu
Copy link
Author

You're right, I created the branch incorrectly... Will fix it later today.

@Florin-Popescu Florin-Popescu reopened this Feb 9, 2023
@Florin-Popescu
Copy link
Author

Fixed. Hope this is a good way to do it.

Copy link
Collaborator

@maxgerhardt maxgerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good an simple to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants